Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9499 Component: Check for existence of window.NodeList on detach #5972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blakekrammes
Copy link
Contributor

@blakekrammes blakekrammes commented Jan 7, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-XXXX

Description

What changed?

Add null-check for window.NodeList in detach method of the Component class. Updated check from typeof ref === NodeList to ref instanceof NodeList since the former returns 'object' and not what we're checking for 'NodeList'.

Screenshot 2025-01-08 at 1 07 42 PM

Why have you chosen this solution?

When the renderer is called via server code, Edit Grids were not able to send their values in emails because window.NodeList was not defined and caused an error. This change checks for both the window object and that NodeList is present on it; it seems like the simplest and most thorough solution.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Manual testing + automated test in formio repo formio/formio#1885.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

  - Edit Grids were not able to send their values in emails because when the renderer was called via server code in formio, window.NodeList was not defined and threw an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant