FIO-9499 Component: Check for existence of window.NodeList on detach #5972
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-XXXX
Description
What changed?
Add null-check for
window.NodeList
in detach method of theComponent
class. Updated check fromtypeof ref === NodeList
toref instanceof NodeList
since the former returns'object'
and not what we're checking for'NodeList'
.Why have you chosen this solution?
When the renderer is called via server code, Edit Grids were not able to send their values in emails because
window.NodeList
was not defined and caused an error. This change checks for both the window object and that NodeList is present on it; it seems like the simplest and most thorough solution.Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Manual testing + automated test in
formio
repo formio/formio#1885.Checklist: